Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix claiming tokens when coin machine is installed and token is unlocked #3115

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix claiming tokens when coin machine is installed and token is unlocked #3115

merged 1 commit into from
Jan 20, 2022

Conversation

chinins
Copy link
Contributor

@chinins chinins commented Jan 18, 2022 •
edited
Loading

Description

This PR fixes the bug where you can't activate tokens when coin machine is installed and token is still locked.

The fix is to add tokenLockingAddress to the deployTokenAuthority transaction when you enable coin machine.

Testing:

  • create a colony
  • mint tokens
  • install & enable coin machine
  • send tokens to coin machine
  • buy tokens
  • create a payment
  • activate tokens

All of this operations should work without any problems. Before the fix the activate tokens part wouldn't work.

Changes 🏗

  • update extensionEnable saga

Resolves #3033

@chinins chinins added the bug label Jan 18, 2022
@chinins chinins self-assigned this Jan 18, 2022
@chinins chinins marked this pull request as draft January 18, 2022 22:29
@chinins chinins force-pushed the fix/3033-token-activaiton-problem branch from fa0b8ed to 9c3bfec Compare January 19, 2022 21:46
@chinins chinins force-pushed the fix/3033-token-activaiton-problem branch from 9c3bfec to 008bf04 Compare January 19, 2022 21:48
@chinins chinins requested a review from a team January 19, 2022 22:07
@chinins chinins marked this pull request as ready for review January 19, 2022 22:07
danbr
danbr approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@danbr danbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Screenshot 2022-01-19 at 20 22 34

ArmandoGraterol
ArmandoGraterol approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@ArmandoGraterol ArmandoGraterol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a deal, short and sweet! Good job

arrenv
arrenv approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works great for me.

@chinins chinins merged commit fe01a87 into master Jan 20, 2022
@chinins chinins deleted the fix/3033-token-activaiton-problem branch January 20, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arrenv arrenv arrenv approved these changes

@ArmandoGraterol ArmandoGraterol ArmandoGraterol approved these changes

@danbr danbr danbr approved these changes

Assignees

@chinins chinins

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't activate tokens when coin machine is installed & token is locked
4 participants
@chinins @danbr @ArmandoGraterol @arrenv