Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy to KYCDialog #3092

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Add copy to KYCDialog #3092

merged 2 commits into from
Jan 14, 2022

Conversation

danbr
Copy link
Contributor

@danbr danbr commented Jan 9, 2022

Description

This PR adds copy to the loading spinner in KYCDialog.

Screenshot 2022-01-09 at 13 30 06

New stuff

  • New loading message in KYCDialog.

How to test

GetWhitelisted.tsx
*replace with true

const openKYCDialog = useCallback(() => {
 return true
 ? // data?.processedMetaColony?.colonyAddress === colonyAddress
 openSynapsEmailDialog({ colonyAddress, onClose: openSynapsDialog })
 : openCompleteKYCDialog();
 }

SynapsKYCDialog.tsx
*remove isLoading condition

{/* {isLoading && ( */}
 <SpinnerLoader
 loadingText={MSG.loadingText.defaultMesage}
 appearance={{ size: 'large' }}
 />
 {/* )} */}

Steps:
*Install whitelist ext with KYC (do not whitelist an address)
*Install coinMachine
*Go to buy tokens page
*Click get whitelisted button
*Click next button

Resolves #2903

@danbr danbr added the bug label Jan 9, 2022
@danbr danbr requested a review from a team January 9, 2022 18:38
@danbr danbr self-assigned this Jan 9, 2022
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one point regarding my comment on CSS targeting.

kyc-loading

Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@danbr danbr force-pushed the fix/2903-synaps-copy-loading branch from 1cc4d4d to 1f82d7f Compare January 14, 2022 01:29
@danbr danbr merged commit dd82198 into master Jan 14, 2022
@danbr danbr deleted the fix/2903-synaps-copy-loading branch January 14, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coin Machine - Microcopy for Synaps Pre-Loading
4 participants