Fix motions using old motion events #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrenv
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Seems to be only showing the correct events now, having tested a few cycles of the steps as described with and without your updates.
Good stuff!
Before
Should show only the annotation and the creation event.
After
Correctly shows only the annotation and the creation event.
ArmandoGraterol
force-pushed
the
fix/issue-2845-wrong-motion-events
branch
from
54cba57 to
9457df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the motions using events from previous instances of the voting reputation extension. The queries would use old events if the current motion id corresponds to any old motion id, so now we need to filter by the current extension's address.
In order to test, you will need to install the voting reputation extension, do some motions, and then uninstall and install the extension and do more motions and see if there are any events that don't correspond with the motions.
To see the bug in action, aside from following the instructions I wrote above in
master, you can check the Roadrunner colony on QA: https://qaxdai.colony.io/colony/roadrunnerResolves #2845 and #2846