Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token info popover to Funding and Token Activation #3067

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

ArmandoGraterol
Copy link
Contributor

Cherry-picked commit added by Raul to extract the "Add token to metamask" button of the token info popover.

According to Product, the current implementation is good enough as it is, so this PR is mostly to add the token info popover to the token action popover and the colony funding page token card as those seen like places where the user would expect to find this popover.

Resolves #3042

@ArmandoGraterol ArmandoGraterol requested a review from a team December 20, 2021 20:17
@ArmandoGraterol ArmandoGraterol self-assigned this Dec 20, 2021
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Nice one, looks good to me.

add-to-metamask-1

add-to-metamask-4

add-to-metamask-2

add-to-metamask-3

Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@ArmandoGraterol ArmandoGraterol force-pushed the feature/issue-3042-add-token-metamask branch from 94ea462 to fe0ff3c Compare December 21, 2021 21:00
@ArmandoGraterol ArmandoGraterol merged commit f2fbd0c into master Dec 21, 2021
@ArmandoGraterol ArmandoGraterol deleted the feature/issue-3042-add-token-metamask branch December 21, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easily add the token of a colony to a users wallet
4 participants