Fix duplicate events on events page

[agustif]

Description

• Make sure duplicate events are not possible on events list component in events page.
• Sorry team, this one is a hard to reproduce bug from metacolony, if anyone knows how to test it direclty with metacolony prod data that'd be nice..
  Otherwise, we can introduce artificially duplicate streamedEvents at the new Set:

  const {
    data,
    loading: subgraphEventsLoading,
    error,
  } = useSubgraphEventsSubscription({
    variables: {
      skip: dataPage === 1 ? 0 : ITEMS_PER_PAGE * dataPage,
      first: ITEMS_PER_PAGE,
      colonyAddress: colonyAddress.toLowerCase(),
      sortDirection: 'desc',
    },
    onSubscriptionData: ({ subscriptionData: { data: newSubscriptionData } }) =>
      setStreamedEvents([
        ...new Set([
          ...streamedEvents,
          ...streamedEvents,
          ...(newSubscriptionData?.events || []),
        ]),
      ]),
  });

and see if Set catches and removes 'em.

Changes 🏗

• Wrap current array for events into set, so it filters them by ID.

Minor cosmetic changes ⚰️

• setstreamedEvents uppercased to -> setStreamedEvents

TODO

Resolves #3045

[ArmandoGraterol]

Well, with the example you provided it seems to be working, and in theory, it should work with prod's data, so I guess it's good to go!

[agustif]

Well, with the example you provided it seems to be working, and in theory, it should work with prod's data, so I guess it's good to go!

Thanks for the input @ArmandoGraterol . Do you think I should look in adding this in Actions Page too? Doesn't think the a bug has showed there yet, but might be good for -guard railing- in the future? Will look into it

[ArmandoGraterol]

Well, with the example you provided it seems to be working, and in theory, it should work with prod's data, so I guess it's good to go!

Thanks for the input @ArmandoGraterol . Do you think I should look in adding this in Actions Page too? Doesn't think the a bug has showed there yet, but might be good for -guard railing- in the future? Will look into it

I haven't seen that happen in the action list, so I don't think it's necessary right now but if it doesn't hurt performance then you can try adding it there too

[chinins]

Seems to be working. I agree with Armando that we shouldn't change anything in the ActionsList because the logic there is a bit different.