-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conditions for red color text in remaining display widgets #3020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected, nice work!
I do have a couple of other things I noticed that you may also be able to include in this PR. However, let me know if you think these should be raised in separate issues.
#1 - Sold out warning on batches is not displaying if the total tokens in the coin machine are sold out.
#2 - Available tokens on batches not correct.
src/modules/dashboard/components/CoinMachine/RemainingDisplayWidgets/RemainingTokens.tsx
Show resolved
Hide resolved
@arrenv, regarding the sold out issue I will fix it in this PR. Regarding the second issue with incorrect amounts, I think it should be a different issue. Do you have any per user purchase limit that might intervene with this or anything else? I didn't experience this issue. |
It is all default, as in the per user limit is 100% and batch size is 400,000. You do have to let the next batch start though, which is why I skipped forward an hour. I ran the following in terminal.
|
ff97f86
to
e0a60f7
Compare
@arrenv, can you please test the token numbers & soldout issues again? Maybe there is something wrong with pulling data from the contracts... The logic is working properly for me (and I had less tokens left than the target): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, the color of all 3 widgets is working as expected! And I agree that the second issue should be separated as it's not related to this PR and it may not be a simple, small fix.
994e64f
to
147e3e6
Compare
147e3e6
to
8061e15
Compare
Description
This PR fixes the conditions for color coding of the remaining display widgets (time & tokens)
Changes 🏗
RemainingTokensValue
RemainingTokens
&RemainingTime
Resolves #3012