-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prices for Coinmachine periods with no sales #3019
Conversation
I think we'll have to find a fix for this as well, but I really have no good idea on how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
Thank you @area for fixing my shitty math!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
7a96a51
to
49e8135
Compare
If there wasn't a sale in the first period
For the metacolony only
This PR updates the logic for calculating historical prices for coinmachine periods where no tokens have been sold. I've just lightly touched the maths rather than anything more radical, and as a result there are two wrinkles here that I have not solved, but for the majority of historical periods the prices are now correct.
PriceEvolutionSet
event on the contracts, which has a boolean argument to track whether the price is evolving or not.We can either fix these here (I suspect the second point, at least, needs to be fixed, with Raul's proposed solution the way to go), or elsewhere.
Resolves #3006
Resolves #2995
Resolves #2938
Resolves #2996
Resovles #3026