Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "Report a bug" link in user dropdown menu #3007

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

thycommodore
Copy link
Contributor

Description

  • In the user menu (upper right, click avatar), changed the "Report a Bug" link to point to Productboard.

Changes 🏗

  • "Report a Bug" link was updated to point to our active bug repo

Resolves #3001

@arrenv arrenv requested a review from a team December 6, 2021 11:56
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the update. I have just provided a comment regarding the linting error.

@@ -119,7 +119,7 @@ const AvatarDropdownPopover = ({
<DropdownMenuSection separator>
<DropdownMenuItem>
<ExternalLink
href="https://colony.canny.io"
href="https://portal.productboard.com/colony/1-colony-portal/tabs/4-bugs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is giving a lint error due to how long the URL is on the line.

You can get around this by setting the URL as a constant. For example:

long-urls

@rdig
Copy link
Member

rdig commented Dec 6, 2021

@arrenv maybe jump in and do this change yourself to get this merged faster ?

Unless @thycommodore wants to play around with our codebase some more :)

@arrenv
Copy link
Member

arrenv commented Dec 6, 2021

@rdig yeah, happy to. Just thought I would give @thycommodore a chance to update, up to you Commodore, I can take over if you prefer.

@thycommodore
Copy link
Contributor Author

@arrenv yes can you please resolve? Thank you for educating me!

@arrenv arrenv self-assigned this Dec 6, 2021
@arrenv arrenv force-pushed the maintenance/3001-replace-report-a-bug-link branch from 7dff8e7 to 1a2d778 Compare December 6, 2021 19:28
@arrenv arrenv requested a review from a team December 6, 2021 19:29
@arrenv
Copy link
Member

arrenv commented Dec 6, 2021

As requested, I have taken over this PR.

I have moved the URL into a constants file and pulled from that, this is probably something we could do more of where possible if mutually agreed. I will raise during our focus on maintenance in the next quarter.

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@@ -165,3 +165,6 @@ export const TOKEN_LOGOS_REPO_URL = `https://raw.githubusercontent.com/trustwall
export const NETWORK_RELEASES_URL = `https://github.com/JoinColony/colonyNetwork/releases/tag`;

export const SMALL_TOKEN_AMOUNT_FORMAT = '0.00000...';

export const FEEDBACK_LINK =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually keep links like these inside the component itself, but It's ok for it being in here as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as though it is used in a couple of areas, I thought it might be good to have here. Will make note of this in future though.

@arrenv arrenv merged commit c47ec83 into master Dec 6, 2021
@arrenv arrenv deleted the maintenance/3001-replace-report-a-bug-link branch December 6, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Report Bugs" in the top right dropdown menu still links to Canny.
3 participants