-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed "Report a bug" link in user dropdown menu #3007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the update. I have just provided a comment regarding the linting error.
@@ -119,7 +119,7 @@ const AvatarDropdownPopover = ({ | |||
<DropdownMenuSection separator> | |||
<DropdownMenuItem> | |||
<ExternalLink | |||
href="https://colony.canny.io" | |||
href="https://portal.productboard.com/colony/1-colony-portal/tabs/4-bugs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arrenv maybe jump in and do this change yourself to get this merged faster ? Unless @thycommodore wants to play around with our codebase some more :) |
@rdig yeah, happy to. Just thought I would give @thycommodore a chance to update, up to you Commodore, I can take over if you prefer. |
@arrenv yes can you please resolve? Thank you for educating me! |
7dff8e7
to
1a2d778
Compare
As requested, I have taken over this PR. I have moved the URL into a constants file and pulled from that, this is probably something we could do more of where possible if mutually agreed. I will raise during our focus on maintenance in the next quarter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
@@ -165,3 +165,6 @@ export const TOKEN_LOGOS_REPO_URL = `https://raw.githubusercontent.com/trustwall | |||
export const NETWORK_RELEASES_URL = `https://github.com/JoinColony/colonyNetwork/releases/tag`; | |||
|
|||
export const SMALL_TOKEN_AMOUNT_FORMAT = '0.00000...'; | |||
|
|||
export const FEEDBACK_LINK = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually keep links like these inside the component itself, but It's ok for it being in here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as though it is used in a couple of areas, I thought it might be good to have here. Will make note of this in future though.
Description
Changes 🏗
Resolves #3001