Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if current user colony is Metacolony before opening SynapsKYCDialog #2973

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

agustif
Copy link
Contributor

@agustif agustif commented Nov 29, 2021

Description

  • Make sure current colony is metacolony.

Changes 🏗

  • Adds a en equality check as suggested by @rdig in the issue on the GetWhitelisted openKYCDialog
    return data?.processedMetaColony?.colonyAddress === colonyAddress
      ? openSynapsDialog({ colonyAddress })
      : openCompleteKYCDialog();
  }, [data, openSynapsDialog, colonyAddress, openCompleteKYCDialog]);
  • Need to test it works properly yet

Resolves #2947

@agustif agustif self-assigned this Nov 29, 2021
rdig
rdig previously approved these changes Nov 29, 2021
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@agustif agustif force-pushed the fix/2947-kyc-meta-only branch from 88995ef to 9adc1d9 Compare November 30, 2021 13:12
@agustif agustif marked this pull request as ready for review November 30, 2021 13:49
@rdig rdig dismissed their stale review November 30, 2021 14:10

Dismissed until git history is fixed

@agustif agustif marked this pull request as draft November 30, 2021 14:18
@agustif agustif force-pushed the fix/2947-kyc-meta-only branch from 9adc1d9 to 6495490 Compare November 30, 2021 14:22
@agustif agustif marked this pull request as ready for review November 30, 2021 14:24
@agustif agustif requested a review from rdig November 30, 2021 14:24
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge now.

Please be more mindful when doing force pushes in the future

@agustif agustif merged commit 885fee3 into master Nov 30, 2021
@agustif agustif deleted the fix/2947-kyc-meta-only branch November 30, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only allow the SynapsKYCDialog on Metacolony
2 participants