Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh sales data period query after extension install #2971

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Refresh sales data period query after extension install #2971

merged 3 commits into from
Nov 30, 2021

Conversation

alicjakujawa
Copy link
Contributor

Description

This PR fixes PreviousSalesTable widget caching issue. It was showing data from previous sales (but from last coin extension address) after coin machine extension reinstall

Changes 🏗

  • Updated refreshExtension to update SalesPeriodData after coin machine extension install

Resolves #2970

@alicjakujawa alicjakujawa requested a review from a team November 29, 2021 12:38
@alicjakujawa alicjakujawa self-assigned this Nov 29, 2021
arrenv
arrenv reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alicjakujawa what is the best way to replicate the issue to test?

I have tried customising the Coin Machine extension parameters, depreciating, uninstalling the extension. Then re-ininstalling and enabling with new parameters, however, it shows with the correct new details, without a refresh.

@alicjakujawa
Copy link
Contributor Author

Hi @alicjakujawa what is the best way to replicate the issue to test?

I have tried customising the Coin Machine extension parameters, depreciating, uninstalling the extension. Then re-ininstalling and enabling with new parameters, however, it shows with the correct new details, without a refresh.

  1. Install coin machine, send tokens to coin machine address
  2. Buy tokens
  3. Make sure that you have data in previous sales table
  4. Reinstall coin machine extension
  5. Go back to Coin machine page and see previous sales data

arrenv
arrenv approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Mine was refreshing. I was able to replicate though and see that your fix works great!

Before

before-cached-sales-data

After

after-cached-sales-data

ArmandoGraterol
ArmandoGraterol approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@ArmandoGraterol ArmandoGraterol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!

rdig
rdig approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@alicjakujawa alicjakujawa merged commit 6bf4dd6 into master Nov 30, 2021
@alicjakujawa alicjakujawa deleted the bug/issue-2970-previous-sale-caching-bug branch November 30, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arrenv arrenv arrenv approved these changes

@ArmandoGraterol ArmandoGraterol ArmandoGraterol approved these changes

@rdig rdig rdig approved these changes

Assignees

@alicjakujawa alicjakujawa

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix caching issue in previous sales table
4 participants
@alicjakujawa @rdig @ArmandoGraterol @arrenv