Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide userLimitFraction during coin machine installation when there is no whitelist #2958

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

chinins
Copy link
Contributor

@chinins chinins commented Nov 24, 2021

Description

This PR hides per person limit field when there is no whitelist. This limit is not enforced when there is no whitelist (you can see the explanation in the thread of the corresponding issue) so Jack said to hide it (like we do with the whitelist address field).

To test - try enabling coin machine with whitelist & without.

resolves #2934

@chinins chinins added the bug label Nov 24, 2021
@chinins chinins requested a review from a team November 24, 2021 12:44
@chinins chinins self-assigned this Nov 24, 2021
Copy link
Contributor

@ArmandoGraterol ArmandoGraterol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Working as expected

@chinins chinins force-pushed the fix/2934-remove-per-person-limit-when-no-whitelist branch from bfaef15 to dc7b07c Compare November 24, 2021 20:15
@chinins chinins merged commit abd8a77 into master Nov 24, 2021
@chinins chinins deleted the fix/2934-remove-per-person-limit-when-no-whitelist branch November 24, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum per person purchase limit is not enforced.
2 participants