Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix countdown timer on motion finished #2946

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

ArmandoGraterol
Copy link
Contributor

Fixed the countdown timer appearing as Timeout when the motion failed/passed/failed but not finalizable

Resolves #2944

@ArmandoGraterol ArmandoGraterol requested a review from a team November 23, 2021 00:29
@ArmandoGraterol ArmandoGraterol self-assigned this Nov 23, 2021
@arrenv
Copy link
Member

arrenv commented Nov 23, 2021

Hi @ArmandoGraterol, I have only explored motions a little bit. To speed things up for me. what is the best way to test this?

@ArmandoGraterol
Copy link
Contributor Author

Hi @ArmandoGraterol, I have only explored motions a little bit. To speed things up for me. what is the best way to test this?

You test this by making a motion for anything and finishing it, then check if the count down timer appears at all.

By finishing it I mean that:

  • The motion passed due to the YAY side winning either in the staking phase or in the voting phase.
  • The motion failed due to the NAY side winning, again either in the staking phase or the voting phase.
  • The motion failed but is not "finalizable" due to neither side winning in the staking phase.

Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good - working as expected.

Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @chinins, working as required.

@ArmandoGraterol ArmandoGraterol force-pushed the fix/issue-2944-countdown-timer branch from 994f648 to 0fb474a Compare November 23, 2021 18:12
@ArmandoGraterol ArmandoGraterol merged commit 11400b7 into master Nov 23, 2021
@ArmandoGraterol ArmandoGraterol deleted the fix/issue-2944-countdown-timer branch November 23, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix 'Timeout' display in CountDownTimer
3 participants