Optimize Reputation Fetching for Display Purposes #2809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the way we fetch user reputation for display purposes, by getting just the values, omitting the proofs.
This is done by calling the
getReputationWithoutProofs
common extension available from this version ofcolonyJS
onward on the `colonyClient.The problem with fetching eveything, including proofs is that behind the scenes, every call also replays back all the full reputation state. Multiply this by a large number of requests and we up hammering the reputation oracle pretty hard.
Note: that for places where we still need the proofs for the user's reputation (eg: all sagas) we still use the "heavy" version of this call:
getReputation
The bulk of the changes that enabled making this change were actually on the
colonyJS
side: JoinColony/colonyJS@2d6c84d...ab5065bChanges
colonyNetwork
submodule to latestdevelop
branch changes -- this brought in the new reputation oracle endpointcolonyJS
to latestbeta
release -- this brought in the newgetReputationWithoutProofs
colony client common extensioncolony
,user
,motions
client resolver to fetch reputation without proofsResolves #2781