Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canUserStake logic in StakingWidget #2792

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

chinins
Copy link
Contributor

@chinins chinins commented Oct 15, 2021

Description

This PR fixes the logic of canUserStake in StakingWidget.

I wasn't able to reproduce the bug in development but I looked for possible reasons it happens & ways to solve and I think that's the best guess for now. I think that the problem is in rounding when submitting the stake. This change will hopefully allow to stake the last minimal bit that's there.

resolves #2733

@chinins chinins added the bug label Oct 15, 2021
@chinins chinins requested a review from a team October 15, 2021 11:50
@chinins chinins self-assigned this Oct 15, 2021
Copy link
Contributor

@ArmandoGraterol ArmandoGraterol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I tested it by trying to stake the smallest amounts possible and it seems to be working fine 👍

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving it, but I can't really test it.

My plan is to deploy this to staging and enlist the help of someone who ran into this in an attempt to replicate it.

In the mean time, you can merge it.

Nice work! 💯

@chinins chinins merged commit bde6bc1 into master Oct 17, 2021
@chinins chinins deleted the fix/2733-fully-staking-moiton branch October 17, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to fully stake a Motion - Stuck at 99%
3 participants