Fix ipfs domain error showing "Ooops, action not found" #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdig
approved these changes
Sep 23, 2021
ArmandoGraterol
force-pushed
the
bug/issue-2739-ipfs-domain-error
branch
from
e60d125 to
2313927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managed to replicate this once on QA.
It seems like the "Ooops, action not found" page would show if the IPFS failed to retrieve the domain data due to a time-out. With these changes, we can at least show the action/motion page even when the IPFS fails, so the user is no longer left confused about whether the transaction was created or not.
The changes should affect specifically the edit domain action. create domain and edit domain motion.
Resolves #2739