Allow claim action for every logged in person #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArmandoGraterol
approved these changes
Aug 17, 2021
rdig
approved these changes
Aug 18, 2021
| @@ -136,7 +126,7 @@ const UnclaimedTransfersItem = ({ | |||
| error={ActionTypes.COLONY_CLAIM_TOKEN_ERROR} | |||
| success={ActionTypes.COLONY_CLAIM_TOKEN_SUCCESS} | |||
| transform={transform} | |||
| disabled={!userHasPermission || !isNetworkAllowed} | |||
| disabled={!isNetworkAllowed || ethereal} | |||
There was a problem hiding this comment.
So this needs to check if the user has a registered profile as well, not just that it's not an ethereal wallet.
Something like this:
const { walletAddress, username, ethereal } = useLoggedInUser();
const hasRegisteredProfile = !!username && !ethereal;This is not necessarily something in the contracts, but it something we don't allow in the dapp, if you don't have your profile registered first.
alicjakujawa
force-pushed
the
bug/issue-2647-everyone-can-claim
branch
from
82a017d to
3609e79
Compare
alicjakujawa
force-pushed
the
bug/issue-2647-everyone-can-claim
branch
from
3609e79 to
a7d3cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates logic for claim button.
Resolves #2647