Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UserPicker size and validation #2583

Merged
merged 7 commits into from
Jul 5, 2021
Merged

Update UserPicker size and validation #2583

merged 7 commits into from
Jul 5, 2021

Conversation

ArmandoGraterol
Copy link
Contributor

  • Added a standard size for UserPicker component
  • Updated validation of UserPicker value
  • Updated conditional in charge of showing the errors on Input component

Resolves DEV-449

@ArmandoGraterol ArmandoGraterol requested a review from a team July 1, 2021 15:53
@ArmandoGraterol ArmandoGraterol self-assigned this Jul 1, 2021
@linear
Copy link

linear bot commented Jul 1, 2021

DEV-449 Update UserPicker avatar and fix form validation on user select

https://www.notion.so/colony/QA-008ecbf3acb84c6281ef8b619f5fcb34?p=53e7d9a061934f9c944c06482349d5be

chinins
chinins reviewed Jul 2, 2021
View reviewed changes
Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all seems good and working well. I just have a question about isNil (please, have a look at my comment).

src/modules/core/components/Fields/InputStatus/InputStatus.tsx Outdated Show resolved Hide resolved
@ArmandoGraterol ArmandoGraterol force-pushed the bug/dev-449-user-picker-styles-validation branch from 76704dd to 4c732b8 Compare July 2, 2021 17:17
@ArmandoGraterol ArmandoGraterol requested a review from chinins July 2, 2021 17:51
Base automatically changed from feature/reputation-voting to master July 5, 2021 11:17
alicjakujawa
alicjakujawa approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@alicjakujawa alicjakujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, apart of this works nice so pre-approving

src/modules/core/components/Fields/InputStatus/InputStatus.tsx Show resolved Hide resolved
chinins
chinins approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@ArmandoGraterol ArmandoGraterol force-pushed the bug/dev-449-user-picker-styles-validation branch from 4c732b8 to 40d167d Compare July 5, 2021 19:26
@ArmandoGraterol ArmandoGraterol merged commit 278f938 into master Jul 5, 2021
@ArmandoGraterol ArmandoGraterol deleted the bug/dev-449-user-picker-styles-validation branch July 5, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinins chinins chinins approved these changes

@alicjakujawa alicjakujawa alicjakujawa approved these changes

Assignees

@ArmandoGraterol ArmandoGraterol

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArmandoGraterol @alicjakujawa @chinins