-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension Manager Upgrade Extensions #2416
Conversation
DEV-257 Extensions Versions Upgrades
This issue will refactor both On the colonyJS side, we need to introduce both a way to generate the new version abis and factories, as well as the logic to make the extension clients aware of versions. On the Extension Manager side, we need some minor UI, resolvers and sagas in order to be able to upgrade the extension client to the new version. |
d2880d9
to
850a75e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works well 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was tough to test but it's all working well and the code is good1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
This PR adds in the ability for the Extension Manager to be able to upgrade currently installed extensions
In order to save time, this PR cherry-pick commits 0e3c3ff 54cd6d9 and 4acd0d2 from #2413
Changes
4
ofcolonyJS
ExtensionUpgrade
subcomponentcolonyExtensionUpgrade
sagaTo test the extension version upgrade
(make sure to run
npm i
and `npm provision first)ColonyNetwork:
colonyNetwork
to commit840e378c
(I used a separate repo, but I guess the one insrc/lib/colonyNetwork
works fine as well...)yarn
(to install packages)yarn run truffle exec ./scripts/deployOldExtensionVersions.js
Dapp:
src/modules/dashboard/sagas/extensions.ts
, change line96
from:to
Demo
Resolves DEV-257