Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display wallet address instead of colony address in membersListItem #2405

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

alicjakujawa
Copy link
Contributor

@alicjakujawa alicjakujawa commented Mar 8, 2021

Description

This PR fixes wrong displaying address in MembersListItem

Changes 🏗

  • colonyAddress changed to walletAddress
  • Use createAddress util before fetching user profile

Resolves DEV-242

@alicjakujawa alicjakujawa requested a review from a team March 8, 2021 12:22
@alicjakujawa alicjakujawa self-assigned this Mar 8, 2021
@linear
Copy link

linear bot commented Mar 8, 2021

DEV-242 Fix user address display on members route

Currently, on the members route, all users are displayed with the same address:

Screenshot from 2021-03-05 21-19-31.png

(note that all have the same address, ending in D23D)

This is a members list issues, since, if clicking the user, and showing the tooltip, the address is displayed correctly:

Screenshot from 2021-03-05 21-20-03.png

You can see this live on xdai with this colony: https://xdai.colony.io/colony/tulip/members

@alicjakujawa alicjakujawa force-pushed the members-page-updates branch from a4c4a0e to c9f6f04 Compare March 8, 2021 13:38

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@alicjakujawa alicjakujawa force-pushed the members-page-updates branch from c9f6f04 to 23b15b7 Compare March 8, 2021 13:39
@alicjakujawa alicjakujawa marked this pull request as ready for review March 8, 2021 13:39
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@alicjakujawa alicjakujawa merged commit 03d13d1 into master Mar 8, 2021
@alicjakujawa alicjakujawa deleted the members-page-updates branch March 8, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants