-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token Activation Feature #2381
Token Activation Feature #2381
Conversation
DEV-212 Add Token Activation button/label to the user navigation
Figma design: |
5a0f458
to
cb137f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several points:
-
as per my comments, could we rename the balances to active/inactive to avoid confusion and have it corresponding to UI? It took me a while to process the
lock
names and wallet balances :) -
focus styles are not correct: i think you need to remove outline & add border color same blue as the font color. Also there is a little stipe of the neighboring color that gets in the outline.
-
from Jack's discord message, I thought we should show decimals when 5 figure numbers or smaller. Right now, no decimals are shown with small numbers.
-
there is no tooltip on hover
-
when I make a payment that increases the token number it doesn't update the dot color & the number of tokens until i refresh the page
How should I test when tokens are inactive? Or is it only possible when we have actions wired?
This helps me for my branch. I will rebase and can actually pass proper props :) |
If some of my comments are not clear or I misunderstood something, please, let me know and we can also have a quick call to discuss. |
|
Of course, the base is good. Let's just connect regarding these balances. I'll ping you in discord. |
9a5aa3e
to
201c80d
Compare
201c80d
to
d81d807
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Apart from some things Olga already mentioned, and these small things I noticed, this looks good
ef02f21
to
aa5a848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine for the most part with this, however, I left some comments that should be improved upon.
As for the thing Olga mentioned, that this is not complete (missing styles, tooltips, etc): please open another issue to track those, and add them in a serparate PR
18e38d2
to
2b03fe9
Compare
b6ca514
to
516d0bb
Compare
165f3ff
to
6d22f18
Compare
Description
This PR adds in button for token activation to user navigation bar
New stuff ✨
Changes 🏗
Deletions ⚰️
TODO ⚰️
Styles updates
Resolves DEV-212