Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add task comment count #2127

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Add task comment count #2127

merged 3 commits into from
Mar 31, 2020

Conversation

ceolson01
Copy link
Contributor

Description

This PR adds a task comment count to the task list item.

New stuff ✨

  • comment icon

Changes 🏗

  • Add basic events to task queries
  • Add comment count to task list item

Screenshot 📷

Screen Shot 2020-03-30 at 5 01 23 PM

Closes #314

@ceolson01 ceolson01 requested a review from chmanie March 30, 2020 22:03
@ceolson01 ceolson01 self-assigned this Mar 30, 2020
@ceolson01 ceolson01 requested a review from rdig March 30, 2020 22:07
@ceolson01 ceolson01 force-pushed the feature/314-task-comment-count branch from 4ce0980 to 934454f Compare March 30, 2020 22:13
rdig
rdig approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @ceolson01 💯

Screenshot from 2020-03-31 11-48-22

src/modules/dashboard/components/TaskList/TaskListItem.tsx Outdated Show resolved Hide resolved
@ceolson01 ceolson01 force-pushed the feature/314-task-comment-count branch from 934454f to d1dfb35 Compare March 31, 2020 14:39
@ceolson01 ceolson01 force-pushed the feature/314-task-comment-count branch from d1dfb35 to 4bf3960 Compare March 31, 2020 14:40
rdig
rdig approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works great! Top marks! 🥇

Screenshot from 2020-03-31 18-29-11

@ceolson01 ceolson01 merged commit 5f0db0d into master Mar 31, 2020
@ceolson01 ceolson01 deleted the feature/314-task-comment-count branch March 31, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdig rdig rdig approved these changes

@chmanie chmanie Awaiting requested review from chmanie

Assignees

@ceolson01 ceolson01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add comment count to task card
2 participants
@ceolson01 @rdig