-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reputation to member popover #2118
Conversation
2c6d625
to
1bb2819
Compare
src/data/queries.graphql
Outdated
@@ -155,6 +155,26 @@ query User($address: String!) { | |||
} | |||
} | |||
|
|||
query UserWithReputation($address: String!, $colonyAddress: String!, $skillId: Int) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially planned to use this query, but later decided to use the UserReputation
query instead, as it was a bit more efficient to handle the data fetching as needed, rather each time a user is fetched. I've left this here, though, as I feel like it might prove useful in the future. Not opposed to removing it, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Can you add this as a comment in the code for the future-us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You bet
@@ -232,7 +232,7 @@ const TaskList = ({ | |||
* If the current user hasn't claimed a profile yet, then don't show the | |||
* subscribe to colony call to action | |||
*/ | |||
hasJoined: username ? hasJoined : true, | |||
hasJoined: username ? !!hasJoined : true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the weird ICU syntax error that would happen sometimes in the colony home (if there are no tasks and the user is not subscribed to the colony)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quirks, all in all fantastic work! I'm happy
src/data/queries.graphql
Outdated
@@ -155,6 +155,26 @@ query User($address: String!) { | |||
} | |||
} | |||
|
|||
query UserWithReputation($address: String!, $colonyAddress: String!, $skillId: Int) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Can you add this as a comment in the code for the future-us?
9652345
to
faff9ee
Compare
Improve appearance typings
Update `UserBadges` query to only query within a colony
* Popovers did not play well with `Table` * Eventually should use this in place of `UserList` in colony admin
`div` cannot appear as a descendant of `<p>`
9775e00
to
6f68e37
Compare
6f68e37
to
9594b33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a rename! All seems well
Description
This PR adds a user's reputation to the member popover.
New stuff ✨
UserReputation
queryUserWithReputation
query (may remove - let's discuss)Changes 🏗
MemberPopover
for use within a colonyNumeral
appearance flexibility & typingsUserBadges
query to only display badges within the current colonyTODO
colonyAddress
andskillId
) toAssignment
instanceCommunity
tabScreenshots 📷
Closes #2026