Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually disable Colony Contract Upgrades #2106

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

rdig
Copy link
Member

@rdig rdig commented Mar 17, 2020

Description

This PR manually disables the colony contract upgrade functionality in preparation for the "burgundy glider" contract version release.

Once we've properly tested the app with the above version of the contracts, we can then remove this hard-coded block.

Changes

  • admin ProfileAdvanced disable colony contract upgrades

Screenshot

Screenshot from 2020-03-17 12-07-32

@rdig rdig added this to the Sprint 46 milestone Mar 17, 2020
@rdig rdig requested review from chmanie and ceolson01 March 17, 2020 10:10
@rdig rdig self-assigned this Mar 17, 2020
@rdig rdig changed the title Manually Manually disable Colony Contract Upgrades Mar 17, 2020
Copy link
Contributor

@ceolson01 ceolson01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll do the trick 🙂

@rdig rdig force-pushed the maintenance/disable-colony-contract-upgrades branch from dfdf423 to 94dfd5a Compare March 17, 2020 14:26
@rdig rdig merged commit dc55be6 into master Mar 17, 2020
@rdig rdig deleted the maintenance/disable-colony-contract-upgrades branch March 17, 2020 14:35
@kronosapiens
Copy link
Member

Thanks! I guess it's not so important but why not modify canBeUpgraded to return false for unsupported versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants