Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle RemoveTaskPayout notification message #2087

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

rdig
Copy link
Member

@rdig rdig commented Mar 5, 2020

Description

This is a simple PR that adds in the required message descriptor in order for the app to be able to handle remove task payout notification events

Besides that, it "fixes" the task payout display, using the Numeral component, as the value that's coming in, is fetched from the task entry in mongo, which is already converted into a human-readable format.

Re-converting it using the unit prop, would only add more decimals then required.

Changes

  • Inbox handle RemoveTaskPayout event type
  • InobxItem don't re-convert task payout amount using the token unit

Screenshots

Remove Task Payout

Before:
Screenshot from 2020-03-05 15-02-37

After:
Screenshot from 2020-03-05 15-10-40

Properly display token amount

Before:
Screenshot from 2020-03-05 15-10-40

After:
Screenshot from 2020-03-05 15-15-01

@rdig rdig added this to the Sprint 45 milestone Mar 5, 2020
@rdig rdig requested review from chmanie and ceolson01 March 5, 2020 13:23
@rdig rdig self-assigned this Mar 5, 2020
Copy link
Member

@chmanie chmanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here!

@rdig rdig merged commit ba025c8 into master Mar 5, 2020
@rdig rdig deleted the fix/handle-removetaskpayout-notification branch March 5, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants