Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structured work to colony home aside #2036

Merged
merged 9 commits into from
Feb 20, 2020

Conversation

ceolson01
Copy link
Contributor

@ceolson01 ceolson01 commented Feb 11, 2020

The branch name for this PR has the wrong issue number 🤦‍♂ it actually closes #2007 but I'm too lazy to change it

⚠️ This branch uses JoinColony/colonyServer#54

Description

This PR adds Programs to the colony home aside, including logic required for admins, non-admins, and creating a new program.

New stuff

  • Program mutations and queries
  • ColonyPrograms component

Screenshots 📷

Admin

No programs

Screen Shot 2020-02-11 at 10 22 52 AM

Draft programs

Screen Shot 2020-02-11 at 10 26 47 AM

Published programs

Screen Shot 2020-02-11 at 10 27 23 AM

Non-admin

No (published) programs

Screen Shot 2020-02-11 at 10 24 59 AM

Published programs

Screen Shot 2020-02-11 at 10 28 01 AM

Closes #2007

@ceolson01 ceolson01 requested a review from chmanie February 11, 2020 16:50
@ceolson01 ceolson01 self-assigned this Feb 11, 2020
@ceolson01 ceolson01 changed the base branch from master to feature/structured-work February 11, 2020 16:51
@ceolson01 ceolson01 mentioned this pull request Feb 12, 2020
@ceolson01 ceolson01 requested a review from rdig February 13, 2020 00:43
@ceolson01 ceolson01 force-pushed the feature/structured-work branch 2 times, most recently from bdc3106 to 0c296cc Compare February 14, 2020 16:56
@ceolson01 ceolson01 force-pushed the feature/2005-structured-work-aside branch from 55a3a5a to 3dee31b Compare February 14, 2020 17:03
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems fine, but I couldn't render the program page :(

bug-cannot-render-program

Yet the console didn't show anything of relevance:

Screenshot from 2020-02-18 16-06-12

})}
</nav>
{canCreate && (
<Button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, but this should be centered:

Screenshot from 2020-02-18 16-03-25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Fixed 👍

@ceolson01
Copy link
Contributor Author

This all seems fine, but I couldn't render the program page :(

That's okay! The program page arrives via #2045 🙂

Sorry, I probably should have put that in the description

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@ceolson01 ceolson01 merged commit 1876981 into feature/structured-work Feb 20, 2020
@ceolson01 ceolson01 deleted the feature/2005-structured-work-aside branch February 20, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add programs to left aside
2 participants