Prevent finalizing a Task with insufficient domain pot balance #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceolson01
suggested changes
Feb 6, 2020
rdig
force-pushed
the
fix/1952-prevent-finalizing-task-with-more-tokens-then-in-pot
branch
from
dc25d7b to
25f5f25
Compare
|
Yup, took your advice on the domains balances logic and now works like a charm. Thanks! This is ready for another look. |
ceolson01
approved these changes
Feb 7, 2020
rdig
force-pushed
the
fix/1952-prevent-finalizing-task-with-more-tokens-then-in-pot
branch
from
25f5f25 to
cce5935
Compare
rdig
deleted the
fix/1952-prevent-finalizing-task-with-more-tokens-then-in-pot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bad UX pattern where a task can be finalized with a payout larger then available funds in the domain pot.
The user would be allowed to press Finalize Task, generate the transaction, sign it, but as expected, the transaction would fail (with a rather cryptic error message)
The fix for this implies calculating the that task payout relative to the domain pot balance, and in the funds are not sufficient, show a dialog informing the user of that fact, otherwise proceed as nromal.
New stuff
TaskFinalizecomponentTaskFinalizeDialogdialog componentChanges
Taskto extract the finalize button into it's own component (TaskFinalize)Taskto use theROOT_DOMAINconstant, rather then the number1Demo
Resolves #1952
Resolves #1997