Fix task attributes cache #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceolson01
commented
Feb 4, 2020
| address: walletAddress, | ||
| } as UserTasksQueryVariables, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
In theory, this could be done as a cacheUpdates function, but would be quite messy, as it would require us to expand some of our existing queries unnecessarily, just for when this case occurs (user assigns or unassigns themselves). I can't imagine this is going to happen often enough to warrant such implementation.
rdig
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two particular issues, and likely prevents a couple of related cache bugs from surfacing in the future.
Most notably - in cases where an expanded user and their address are both fields on query types, we now accept both fields in mutation results. This solves some cache issues related to task worker assignment not updating immediately in task lists.
Also, this PR ensures that a task is added or removed from the user task list when they've assigned or unassigned themselves, respectively.
Closes #2012