Don't Display UserInfo on Userlist Avatars #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmanie
reviewed
Jan 27, 2020
| }} | ||
| /> | ||
| </p> | ||
| {selectedDomain && selectedDomain.id !== ROOT_DOMAIN && ( |
rdig
deleted the
fix/1913-prevent-user-info-showing-up-in-permissions-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables the
UserInfotooltip on items displayed via aUserListin the admin panel. This was due to both actions firing at the same time: showing userinfo and opening the permission modal resulting in a broken UI state.While I was at it, I also added a simple logic check to display the parent (root) inheritance description text, only if a different domain that root is selected.
Changes
UserListItemdon't showUserInfoon avatarsPermissionsonly show parent inheritance tip on non-root domainsScreenshots
UserInfostill available on the permissions edit modal:Parent inheritance tip only shown on non-root domain:
Resolves #1913