Show Edit Profile Icon for the Current User Only #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceolson01
approved these changes
Jan 21, 2020
rdig
force-pushed
the
fix/1972-profile-edit-icon-visible-on-other-users-profile
branch
from
65a9dff to
3b74f0a
Compare
rdig
deleted the
fix/1972-profile-edit-icon-visible-on-other-users-profile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the user profile would render a profile edit icon (cog wheel) for all users, didn't matter if it was the current user, or someone else.
Granted, the bug was not that severe given that upon clicking it, it would redirect you to your own user profile edit page.
Changes
UserMetanow checks if the rendered user is the currently logged in oneScreenshots
Current user:
Another user:
Resolves #1972