Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token balances #1953

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Fix token balances #1953

merged 3 commits into from
Jan 16, 2020

Conversation

ceolson01
Copy link
Contributor

Description

  • This PR aims to improve the structure of the apollo cache - specifically for token balances, enabling them to update automagically ✨

New stuff ✨

  • dataIdFromObject property in apollo cache

Changes 🏗

  • Use token balances for domains in colony home funding
  • Fix breadcrumb iterator key

@ceolson01 ceolson01 requested review from rdig and chmanie January 15, 2020 18:50
@ceolson01 ceolson01 self-assigned this Jan 15, 2020
rdig
rdig approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this works as advertised for transferring tokens from one pot to another.

Screenshot from 2020-01-16 13-55-15
Screenshot from 2020-01-16 13-55-46
Screenshot from 2020-01-16 13-55-52

There is however another issue here, which we might want to fix as well, but that is your call.

Minting new tokens does not refresh the token balances:

I minted 100 tokens, but the card still showed the old amount:
Screenshot from 2020-01-16 13-54-50

But after a page refresh, the amounts were updated correctly:
Screenshot from 2020-01-16 13-55-15

@chmanie chmanie merged commit c56d91b into master Jan 16, 2020
@chmanie chmanie deleted the fix/token-balances-cache branch January 16, 2020 14:32
chmanie
chmanie approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@chmanie chmanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmanie chmanie chmanie approved these changes

@rdig rdig rdig approved these changes

Assignees

@ceolson01 ceolson01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceolson01 @rdig @chmanie