Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore VCS ignored files #833

Closed
alerque opened this issue Dec 12, 2023 · 1 comment · Fixed by #840
Closed

Ignore VCS ignored files #833

alerque opened this issue Dec 12, 2023 · 1 comment · Fixed by #840
Labels
enhancement New feature or request

Comments

@alerque
Copy link
Contributor

alerque commented Dec 12, 2023

I found that Stylua honors a .styluaignore file, but it would be much more useful to my projects if it would just ignore everything in .gitignore. Ruff and some other formatters do this and it makes it easy to avoid modifying vendored or generated code.
@JohnnyMorganz
Copy link
Owner

I don't remember why we didn't decide to ignore these files in the first place, but sounds reasonable to me.
For some reason we disabled ignoring at

StyLua/src/cli/main.rs

Line 316 in 5de9a1d

.standard_filters(false)

@JohnnyMorganz JohnnyMorganz added the enhancement New feature or request label Dec 23, 2023
dundargoc added a commit to dundargoc/StyLua that referenced this issue Dec 27, 2023
@dundargoc
Skip files in .gitignore.
11ae181 
This is a common behavior of formatters (e.g Ruff and Black) as it's
arguably a more useful default behavior.

Closes JohnnyMorganz#833.
@dundargoc dundargoc mentioned this issue Dec 27, 2023
Merged
dundargoc added a commit to dundargoc/StyLua that referenced this issue Dec 27, 2023
@dundargoc
Skip files in .gitignore.
88335f3 
This is a common behavior of formatters (e.g Ruff and Black) as it's
arguably a more useful default behavior.

Closes JohnnyMorganz#833.
JohnnyMorganz pushed a commit that referenced this issue Dec 30, 2023
@dundargoc
Skip files in .gitignore. (#840)
1989671 
This is a common behavior of formatters (e.g Ruff and Black) as it's
arguably a more useful default behavior.

Closes #833.
@clason clason mentioned this issue Jan 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip files in .gitignore. dundargoc/StyLua
2 participants
@alerque @JohnnyMorganz