forked from rust-lang/rust
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of rust-lang#87700 - kornelski:e530text, r=oli-obk
Expand explanation of E0530 The explanation didn't cover a puzzling case of enum variants missing fields.
- Loading branch information
Showing
1 changed file
with
39 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,57 @@ | ||
A binding shadowed something it shouldn't. | ||
|
||
Erroneous code example: | ||
A match arm or a variable has a name that is already used by | ||
something else, e.g. | ||
|
||
* struct name | ||
* enum variant | ||
* static | ||
* associated constant | ||
|
||
This error may also happen when an enum variant *with fields* is used | ||
in a pattern, but without its fields. | ||
|
||
```compile_fail | ||
enum Enum { | ||
WithField(i32) | ||
} | ||
use Enum::*; | ||
match WithField(1) { | ||
WithField => {} // error: missing (_) | ||
} | ||
``` | ||
|
||
Match bindings cannot shadow statics: | ||
|
||
```compile_fail,E0530 | ||
static TEST: i32 = 0; | ||
let r: (i32, i32) = (0, 0); | ||
let r = 123; | ||
match r { | ||
TEST => {} // error: match bindings cannot shadow statics | ||
TEST => {} // error: name of a static | ||
} | ||
``` | ||
|
||
To fix this error, just change the binding's name in order to avoid shadowing | ||
one of the following: | ||
Fixed examples: | ||
|
||
* struct name | ||
* struct/enum variant | ||
* static | ||
* const | ||
* associated const | ||
``` | ||
static TEST: i32 = 0; | ||
Fixed example: | ||
let r = 123; | ||
match r { | ||
some_value => {} // ok! | ||
} | ||
``` | ||
|
||
or | ||
|
||
``` | ||
static TEST: i32 = 0; | ||
const TEST: i32 = 0; // const, not static | ||
let r: (i32, i32) = (0, 0); | ||
let r = 123; | ||
match r { | ||
something => {} // ok! | ||
TEST => {} // const is ok! | ||
other_values => {} | ||
} | ||
``` |