Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible word embeddings #89

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Flexible word embeddings #89

merged 1 commit into from
Jan 25, 2018

Conversation

saif-ellafi
Copy link
Contributor

@saif-ellafi saif-ellafi commented Jan 24, 2018 •
edited
Loading

Description

We needed word embeddings trait not to include all of AnnotatorModel components. This way, HasWordEmbeddings is just another annotator trait which may or may not be included in custom components.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@saif-ellafi saif-ellafi merged commit aecc18a into master Jan 25, 2018
@maziyarpanahi maziyarpanahi deleted the flexible-word-embeddings branch March 29, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksei-ai aleksei-ai Awaiting requested review from aleksei-ai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saif-ellafi