Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Vivekn sentiment analysis training performance #82

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

saif-ellafi
Copy link
Contributor

@saif-ellafi saif-ellafi commented Jan 12, 2018

Description

  • Improved vivekn training performance
  • Fixed dependency parser tests
  • Separated wordCount from vivekn wordCount
  • New params to customize tokens from corpus

Motivation and Context

Vivekn Sentiment analysis was causing a bottleneck on training and memory consumption. This helps there by reducing the amount of redudant calls during word count.

How Has This Been Tested?

This has been tested utilizing a third party sentiment analysis corpora, works best together with the broadcast and rdd object serialization.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Fixed dependency parser tests
- Separated wordCount from vivekn wordCount
- New params to customize tokens from corpus
@saif-ellafi saif-ellafi merged commit 83a8466 into master Jan 12, 2018
@maziyarpanahi maziyarpanahi deleted the vivekn-sentiment-analysis-training-imp branch March 29, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant