[SPARKNLP-1027] Fix issue with pretrained model #14413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maziyarpanahi
approved these changes
Sep 24, 2024
maziyarpanahi
merged commit cc38757
into
JohnSnowLabs:release/550-release-candidate
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical bug when using pretrained models with AutoGGUFModels.
The file protocol is included in the path while trying to read the model. This has been (temporarily) fixed by removing the protocol from the path string. The file should be local at this point, as it as copied to a temporary local location if it was remote.
How Has This Been Tested?
Tests passing with pretrained models.
Types of changes