Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLAMA2 OpenVINO Position ID Fix #14308

Conversation

rajatkrishna
Copy link
Contributor

Description

Fix llama2 decoder receiving incorrect next position ID.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9304029938

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 62.598%

Files with Coverage Reduction New Missed Lines %
src/main/scala/com/johnsnowlabs/nlp/annotators/DateMatcherUtils.scala 2 86.57%
Totals Coverage Status
Change from base Build 9222504413: -0.01%
Covered Lines: 8959
Relevant Lines: 14312

💛 - Coveralls

@maziyarpanahi maziyarpanahi self-requested a review June 3, 2024 11:47
@maziyarpanahi maziyarpanahi merged commit adc193e into JohnSnowLabs:release/540-release-candidate Jun 3, 2024
6 checks passed
@rajatkrishna rajatkrishna deleted the bugfix/llama2-decode branch June 3, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants