Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve saving bug with multilabel parameter #13842

Conversation

DevinTDHa
Copy link
Member

Description

This PR fixes a bug, preventing annotators to be saved if they had the multilabel parameter.

The Parameter in question is declared as a Param[Boolean] . If declared like that, it does not have a json(Decode|Encode) implemented. This will throw an error when attempting to save the annotator.

Motivation and Context

How Has This Been Tested?

"$Annotator" should "be saved and loaded correctly" type tests are passing again.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5164407885

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 65.879%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/scala/com/johnsnowlabs/nlp/HasClassifierActivationProperties.scala 0 1 0.0%
Totals Coverage Status
Change from base Build 5153985393: 0.007%
Covered Lines: 8646
Relevant Lines: 13124

💛 - Coveralls

@maziyarpanahi maziyarpanahi changed the base branch from master to release/444-release-candidate June 8, 2023 08:53
@maziyarpanahi maziyarpanahi merged commit 5b61123 into JohnSnowLabs:release/444-release-candidate Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants