Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): more precise matching #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

markthree
Copy link
Collaborator

In the latest vite demo test, if I manually update an already existing layout, restart is required for it to take effect, this pr fixes the issue。

There are no break changes and it works fine 🥰

A repo that reproduces the problem → vue-layout-demo

Start the service and modify src/_base/layouts/Layout.vue to find the problem.

@markthree
Copy link
Collaborator Author

As usual, merge #141 so that #140 can be closed.

Or we could merge #140 and then merge #141.

@Viliasas
Copy link

Viliasas commented Jul 3, 2024

I've applied your patch with pnpm patch. When I edit the layout or one of its inner components it seems to trigger something, but the data in the browser is not updated. Is there anything special that I need to do to get this working?

@tuanvumaihuynh
Copy link

tuanvumaihuynh commented Aug 4, 2024

Any update here?
@JohnCampionJr

1 similar comment
@vxow
Copy link

vxow commented Aug 13, 2024

Any update here?
@JohnCampionJr

@nos86
Copy link

nos86 commented Sep 22, 2024

Hello guys,
there is any chance to have this pull request integrated in the code?

@markthree, there is any possibility to use your specific branch in my project until PR is not accepted?

Thanks in advance,
Salvo

@markthree
Copy link
Collaborator Author

markthree commented Sep 23, 2024

@nos86 Sorry bro, no progress on this pr at the moment, you can try using vite-plugin-vue-meta-layouts

@chuankaiwei
Copy link

any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants