Wip UI workshop progress #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troyimmediate Replace error-prone call to DestroyImmediate() with Destroy()
(cherry picked from commit c5127aa)
because runtime tests do not work with the current game-ci setup.
update unity package version
sadly this make the test useless for CI, but we can still run them locally
by adding test modes and artifact upload
Update GitHub actions
This is a small step forward towards a more UIToolkity version of the editor. Still lots of dead code around, but time is running out...
| public static string DefaultDataSourceTemplateNamePlaceHolder => "{{name}}"; | ||
| public static string DefaultDataSourceTemplate => | ||
| File.ReadAllText( | ||
| "Packages/de.jochenheckl.unity.databinding/Editor/DefaultDataSourceTemplate.txt" |
There was a problem hiding this comment.
Could that break with new Unity versions etc.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.