Stream Episode 9 #42
Merged
Stream Episode 9 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still some issues in mocking the ViewModel/ViewModelactory #29
…gment view states Added the javax dependency to androidTest variant Removed the READ_PHONE_STATE since the SmsManager was still accessible on a Android Oreo device, so this was a temporary bug, now fixed from Google Worked on new view states for the FavoritesFragment: - Error state - Empty state - Some improvements on success state Test DI still not working, causing problems with UI unit tests (not able to mock the ViewModel). #29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sms modularisation
More UI unit tests for
FavoritesFragmentRemove READ_PHONE_STATE permission
Add tests related to
FavorieFragmentview statesEmptyViewstateErrorViewstateTest DI still not working, so this is causing problems with some UI unit tests (not
able to mock the ViewModel).