Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Minor Issue) Serial output always starts with [0m #54

Open
jeroenst opened this issue Jul 4, 2019 · 3 comments
Open

(Minor Issue) Serial output always starts with [0m #54

jeroenst opened this issue Jul 4, 2019 · 3 comments

Comments

@jeroenst
Copy link
Contributor

jeroenst commented Jul 4, 2019

Describe the bug
When serial output is enabled each line is started with [0m (shown on arduino serial monitor)

To Reproduce
Steps to reproduce the behavior:

  1. Install Arduino
  2. Upload a sketch containing remote debug with serial output enabled
  3. Look in the serial monitor

Expected behavior
A line on the serial monitor should not start with [0m

Screenshots
If applicable, add screenshots to help explain your problem.

Arduino Information:

  • OS: Linux Mint
  • IDE Arduino
  • IDE Version 1.8.9
  • Board ESP32

Additional context
Add any other context about the problem here.
@jeroenst jeroenst changed the title Serial output always starts with [0m (Minor Issue) Serial output always starts with [0m Jul 4, 2019
@jeroenst
Copy link
Contributor Author

jeroenst commented Jul 22, 2019 •
edited
Loading

To solve this issue change line 1197 to

if (_showColors) _bufferPrint.concat(COLOR_RESET);

@jeroenst
Copy link
Contributor Author

Accidentally closed..

@jeroenst jeroenst reopened this Jul 25, 2019
jeroenst pushed a commit to jeroenst/RemoteDebug that referenced this issue Jul 25, 2019
Solved Bug JoaoLopesF#54 (Minor Issue) Serial output always starts wi…
e72a2fd 
…th [0m
@jeroenst jeroenst mentioned this issue Jul 25, 2019
Open
@jeroenst
Copy link
Contributor Author

Created pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeroenst