Fix UI freeze if permissions are disabled while Jitouch is running #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronkollasch
force-pushed
the
fix-ui-freeze
branch
from
13546b8 to
8d0397c
Compare
After a delay, the OS will detect the CGEventTap has timed out and will send a kCGEventTapDisabledByTimeout event. This event will now trigger an exit(). Fixes #5
aaronkollasch
force-pushed
the
fix-ui-freeze
branch
from
8d0397c to
ae0d1be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5 describes an indefinite UI non-responsiveness that occurs if Accessibility permissions are revoked. This is due to Jitouch's
CGEventTapcallback that receives user input events but cannot pass them along due to a lack of permissions.After a delay, the OS normally detects the CGEventTap has timed out and sends a
kCGEventTapDisabledByTimeoutevent to Jitouch'sCGEventCallback. However, this event was ignored, allowing Jitouch to continue dropping all mouse and keyboard events.Now, if CGEventCallback receives a kCGEventTapDisabledByTimeout event, it will trigger Jitouch to exit(). CGEventCallback will also handle kCGEventTapDisabledByUserInput gracefully, by returning the input event unchanged.
Fixes #5
See: