fix security issue OWASP-BLT#1552

JisanAR03 · Nov 3, 2023 · d10e675 · d10e675
1 parent 3eacb34
commit d10e675
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/website/views.py b/website/views.py
@@ -1989,7 +1989,10 @@ def get_score(request):
 
 
 def comment_on_issue(request, issue_pk):
-
+    try:
+        issue_pk = int(issue_pk)
+    except ValueError:
+        raise Http404("Issue does not exist")
     issue = Issue.objects.filter(pk=issue_pk).first()
 
     if request.method == "POST" and isinstance(request.user,User):
@@ -2008,10 +2011,7 @@ def comment_on_issue(request, issue_pk):
 
             if parent_comment == None:
                 messages.error(request,"Parent comment doesn't exist.")
-                if isinstance(issue_pk, int):  # Check if issue_pk is an integer
-                    return redirect(f"/issue2/{issue_pk}")
-                else:
-                    raise Http404("Issue does not exist")
+                return redirect(f"/issue2/{issue_pk}")
 
             Comment.objects.create(
                 parent = parent_comment,