Fix for #127 - Use common dir for Nvidia Passthrough

[dalgibbard]

As per title; proposed fix for nvidia mounting issues in 24.04; mount the entire nvidia common module path, instead of the individual files which are usually presented.

Before:

systemd-run --collect --property=Delegate=yes --property=RestartForceExitStatus=133 --property=SuccessExitStatus=133 --property=TasksMax=infinity --property=Type=notify --setenv=SYSTEMD_NSPAWN_LOCK=0 --property=KillMode=mixed --unit=jlmkr-gpu --working-directory=./jails/gpu '--description=My nspawn jail gpu [created with jailmaker]' --setenv=SYSTEMD_SECCOMP=0 -- systemd-nspawn '--property=DeviceAllow=/dev/nvidia-uvm rwm' '--property=DeviceAllow=/dev/nvidia-uvm-tools rwm' '--property=DeviceAllow=/dev/nvidiactl rwm' '--property=DeviceAllow=/dev/nvidia-modeset rwm' --property=DeviceAllow=/dev/dri/renderD128 '--property=DeviceAllow=/dev/dri rw' '--property=DeviceAllow=/dev/shm rw' --bind-ro=/sys/module --boot --inaccessible=/sys/module/apparmor --quiet --keep-unit --machine=gpu --directory=rootfs --capability=all --bind-ro=/usr/lib/x86_64-linux-gnu/nvidia/current/libnvidia-cfg.so.545.23.08 --bind-ro=/usr/lib/x86_64-linux-gnu/nvidia/current/libnvidia-ml.so.545.23.08 --bind-ro=/usr/lib/x86_64-linux-gnu/nvidia/current/libnvcuvid.so.545.23.08 --bind-ro=/usr/lib/x86_64-linux-gnu/nvidia/current/libnvidia-nvvm.so.545.23.08 --bind=/dev/nvidia-uvm-tools --bind-ro=/usr/lib/x86_64-linux-gnu/nvidia/current/libnvidia-encode.so.545.23.08 --bind=/dev/nvidia0 --bind-ro=/usr/bin/nvidia-smi --bind-ro=/usr/bin/nvidia-persistenced --bind-ro=/usr/lib/x86_64-linux-gnu/nvidia/current/libcuda.so.545.23.08 --bind-ro=/usr/lib/nvidia/current/nvidia-smi --bind-ro=/usr/lib/x86_64-linux-gnu/nvidia/current/libnvidia-ptxjitcompiler.so.545.23.08 --bind=/dev/nvidiactl --bind=/dev/nvidia-uvm --network-bridge=br0 --resolv-conf=bind-host --bind=/dev/fuse --bind=/dev/shm --bind=/dev/nvidia0 --bind=/dev/nvidiactl --bind=/dev/nvidia-uvm --bind=/dev/nvidia-uvm-tools --bind-ro=/sys/module --inaccessible=/sys/module/apparmor

After:

systemd-run --collect --property=Delegate=yes --property=RestartForceExitStatus=133 --property=SuccessExitStatus=133 --property=TasksMax=infinity --property=Type=notify --setenv=SYSTEMD_NSPAWN_LOCK=0 --property=KillMode=mixed --unit=jlmkr-gpu --working-directory=./jails/gpu '--description=My nspawn jail gpu [created with jailmaker]' --setenv=SYSTEMD_SECCOMP=0 -- systemd-nspawn '--property=DeviceAllow=/dev/nvidia-uvm rwm' '--property=DeviceAllow=/dev/nvidia-uvm-tools rwm' '--property=DeviceAllow=/dev/nvidiactl rwm' '--property=DeviceAllow=/dev/nvidia-modeset rwm' --property=DeviceAllow=/dev/dri/renderD128 '--property=DeviceAllow=/dev/dri rw' '--property=DeviceAllow=/dev/shm rw' --bind-ro=/sys/module --boot --inaccessible=/sys/module/apparmor --quiet --keep-unit --machine=gpu --directory=rootfs --capability=all --bind=/dev/nvidiactl --bind-ro=/usr/lib/nvidia/current/nvidia-smi --bind=/dev/nvidia-uvm --bind-ro=/usr/lib/x86_64-linux-gnu/nvidia/current --bind-ro=/usr/bin/nvidia-persistenced --bind=/dev/nvidia-uvm-tools --bind-ro=/usr/bin/nvidia-smi --bind=/dev/nvidia0 --network-bridge=br0 --resolv-conf=bind-host --bind=/dev/fuse --bind=/dev/shm --bind=/dev/nvidia0 --bind=/dev/nvidiactl --bind=/dev/nvidia-uvm --bind=/dev/nvidia-uvm-tools --bind-ro=/sys/module --inaccessible=/sys/module/apparmor

Where the change is the removal of individual files under /usr/lib/x86_64-linux-gnu/nvidia/current/ and are replaced with just a single mount for the whole directory itself.

[Jip-Hop]

Could you please create a PR against the current develop branch? :)

[dalgibbard]

Could you please create a PR against the current develop branch? :)

Ah, yeah sure, no probs :)