Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same watermark image is behaving differently on ANDROID and IOS when use given position enum #179

Closed
EducoreAPK opened this issue Dec 20, 2023 · 3 comments · Fixed by #180
Assignees
Labels

Comments

@EducoreAPK
Copy link

Describe the bug
When i am adding a watermark image on Android it is working perfectly as expected.
But when working on IOS the watermark image is losing its original aspect ratio and its getting very blurry.

To Reproduce
Steps to reproduce the behavior:

              Marker.markImage({
                    backgroundImage: {
                        src: IMAGEURL,
                        scale: 1,
                    },
                    watermarkImages: [{
                        src: wIMAGEURL,
                        position: {
                            position: Position.bottomLeft,
                        },
                        scale: 0.1,
                        // alpha: 1
                    }],
                    scale: 1,
                    quality: 100,
                }).then((path) => {
                    resolve(path)
                }).catch((error) => {
                    resolve(false)
                })

Expected behavior
IMAGE SHOULD BE SAME ON BOTH ANDROID AND IOS

I m using CameraRoll library to download image afterwards
CameraRoll.save(dPath, { type: 'photo', album: 'EducoreParent' }).then((res) => {
console.log('res', res);
}).catch((error) => {
console.log('error', error);
})

Screenshots
image

Devlopment environment(please complete the following information):

  • OS: MacOS 14.2 (23C64)
  • nodejs: v18.18.0
  • react-native: 0.72.7
  • react-native-image-marker : "^1.1.9"

Smartphone (please complete the following information):

  • Device: IOS 13ProMax - OS: IOS 17.0
    • Device: Pixel 6 - OS: Android 13
JimmyDaddy added a commit that referenced this issue Dec 21, 2023
… and iOS (#180)

* fix: fix #179 Same watermark image is behaving differently on ANDROID and IOS

* ci: update gh action use changed-files

* docs: update readme

* chore: release 1.1.11

---------

Co-authored-by: JimmyDaddy <heyjimmygo@gmail.com>
@JimmyDaddy
Copy link
Owner

@EducoreAPK v1.1.11 is available

@JimmyDaddy JimmyDaddy self-assigned this Dec 21, 2023
@JimmyDaddy JimmyDaddy added the bug label Dec 21, 2023
@JimmyDaddy JimmyDaddy changed the title Same watermark image is behaving differently on ANDROID and IOS Same watermark image is behaving differently on ANDROID and IOS when use given position enum Dec 28, 2023
@JimmyDaddy JimmyDaddy reopened this Dec 28, 2023
JimmyDaddy added a commit that referenced this issue Dec 28, 2023
… IOS when use given position enum

fix #179 Same watermark image is behaving differently on ANDROID and IOS when use given position enum
@JimmyDaddy
Copy link
Owner

@EducoreAPK You can try 1.2.1

@EducoreAPK
Copy link
Author

Working perfectly now. Appreciate your efforts... Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment