Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager/macos): address auto-update regression #2404

Merged
merged 2 commits into from
Feb 26, 2025
Merged

fix(manager/macos): address auto-update regression #2404

merged 2 commits into from
Feb 26, 2025

Conversation

jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Feb 19, 2025 •
edited
Loading

According to electron:

Note: Squirrel.Mac auto update mechanism requires both dmg and zip to be enabled, even when only dmg is used. Disabling zip will break auto update in dmg packages.

@jyyi1 jyyi1 marked this pull request as ready for review February 25, 2025 20:58
@jyyi1 jyyi1 requested a review from a team as a code owner February 25, 2025 20:58
@jyyi1 jyyi1 merged commit 8f2c5c2 into master Feb 26, 2025
28 checks passed
@jyyi1 jyyi1 deleted the junyi/fix-manager-update-mac branch February 26, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbruens sbruens sbruens approved these changes

@fortuna fortuna Awaiting requested review from fortuna

@daniellacosse daniellacosse Awaiting requested review from daniellacosse

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyyi1 @sbruens