fix(client): electron app doesn't respect reflected properties #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
reviewed
Feb 18, 2025
Yeah, hence why I didn't prioritize testing this specifically outside the storybook. My initial guess was that maybe Polymer is interfering with this somehow, but one of these instances occur on a Lit component inside of other Lit component. Surely Polymer doesn't interfere beyond the shadow boundary, if at all? Anyway, I think we should fix this first and then get to the bottom of it. Gotta release. |
sbruens
approved these changes
Feb 19, 2025
daniellacosse
deleted the
daniellacosse/polyfill-reflected-properties
branch
daniellacosse
added a commit
that referenced
this pull request
Feb 20, 2025
* fix(client): electron app doesn't respect reflected properties * Update bandwidth.ts * Update index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the electron app wasn't respecting lit's reflected properties for some reason (Polymer?) - they would show in the storybook but not in the app. I discovered this while forcing in the necessary data for the marketing screenshots. Here it is properly working: