feat(manager): server allowance usage component #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daniellacosse
commented
Dec 13, 2024
daniellacosse
commented
sbruens
reviewed
Dec 13, 2024
server_manager/www/views/server_view/server_allowance_usage/index.ts
Outdated
Show resolved
Hide resolved
| return html` | ||
| <p class="message">${this.message}</p> | ||
| <p class="allowance"> | ||
| <span class="allowance-percentage">${this.formattedPercentage}</span> |
There was a problem hiding this comment.
Add some unit tests to validate the formatted values.
There was a problem hiding this comment.
So we don't really have UI unit tests set up yet - well, we have this approach, but yikes
Some options here -
- use the above approach, drilling down via
querySelectorandshadowRoot- not ideal imo. Klugy, cumbersome, fragile. - set up something better - karma snapshots or storybook test runner. Ideal, but should probably be done in a separate PR.
- Break these out into separate functions and test them that way. Prefer to not let testability determine architecture but would be good enough and kicks the can down the road.
There was a problem hiding this comment.
I'm fine with something like querySelector for now. That's how I tested the contact form logic in the absence of a better testing framework. I really just want something here to prevent regression of this formatting.
jyyi1
reviewed
Dec 20, 2024
| @property({type: String}) message: string; | ||
| @property({type: Number}) allowanceUsed: number; | ||
| @property({type: Number}) allowanceLimit: number; | ||
| @property({type: String}) allowanceUnit: 'gigabyte' | 'terabyte' = 'terabyte'; |
There was a problem hiding this comment.
nit Shall we be "smart" to determine the unit automatically? For example, just let the caller pass a raw bytes: 1,234,567,000, then we automatically display it as 1.23 GB?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.