fix(client/ios): update minimum deployment target to 15.5
#2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellacosse
approved these changes
Dec 10, 2024
fortuna
approved these changes
Dec 10, 2024
| @@ -24,7 +24,7 @@ let package = Package( | |||
| // CocoaLumberjack 3.8.0 dropped support for iOS < 11 and macOS < 10.13. | |||
| // See https://github.com/CocoaLumberjack/CocoaLumberjack/releases/tag/3.8.0. | |||
| // These cannot be upgraded without also upgrading the entire project. | |||
| .iOS(.v13), | |||
| .iOS("15.5"), | |||
There was a problem hiding this comment.
I think you can also use .15_5, but I guess it doesn't matter.
There was a problem hiding this comment.
That's what I thought but you can't. I had it in a previous commit, but it failed to build:
/Users/runner/work/outline-apps/outline-apps/client/src/cordova/apple/OutlineAppleLib/Package.swift:28:14: error: reference to member 'v15_5' cannot be resolved without a contextual type
.iOS(.v15_5),
Turns out only v15 exists: http://go/appledoc/packagedescription/supportedplatform/iosversion/v15. I guess only the v10_X macOS versions specified more granular version types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum deployment version in the XCode project was already upgraded in #2288. This PR updates some trailing instances to match the version set in the XCode project.
iOS 15 recently reached end of life. Anything older reached end of life at least 1 year ago: https://endoflife.date/ios