Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cordova): only pull clipboard text when the add server prompt is requested #1764

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix(cordova): only pull clipboard text when the add server prompt is requested #1764

merged 1 commit into from
Oct 31, 2023

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Oct 31, 2023 •
edited
Loading

tested!

@daniellacosse daniellacosse changed the title fix(cordova): only pull clipboard text when requested in the add dialog fix(cordova): only pull clipboard text when the add server prompt is requested Oct 31, 2023
@daniellacosse daniellacosse added the needs test Pull requests that require tests label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/www/app/app.ts 8% <0%> (ø)

... and 38 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@daniellacosse daniellacosse force-pushed the daniellacosse/paste_fix branch from a2b684e to 40deba5 Compare October 31, 2023 01:19
@Jigsaw-Code Jigsaw-Code deleted a comment from google-cla bot Oct 31, 2023
@daniellacosse daniellacosse marked this pull request as ready for review October 31, 2023 01:20
@daniellacosse daniellacosse requested a review from a team as a code owner October 31, 2023 01:20
@daniellacosse daniellacosse requested a review from fortuna October 31, 2023 01:20
fortuna
fortuna approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Were you able to validate that it's pulling the clipboard when you click add?

@daniellacosse
Copy link
Contributor Author

Thanks for the quick fix! Were you able to validate that it's pulling the clipboard when you click add?

Yep!

@daniellacosse daniellacosse removed the needs test Pull requests that require tests label Oct 31, 2023
@daniellacosse daniellacosse merged commit 425d6c2 into master Oct 31, 2023
20 of 21 checks passed
@daniellacosse daniellacosse deleted the daniellacosse/paste_fix branch March 6, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellacosse @fortuna